martin-g commented on code in PR #3542:
URL: https://github.com/apache/avro/pull/3542#discussion_r2489150499
##########
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StatsServer.java:
##########
Review Comment:
I think we need similar change here as in the HttpServer:
```java
ServletContextHandler sch = new ServletContextHandler();
sch.setServletHandler(handler);
server.setHandler(sch);
```
##########
lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StaticServlet.java:
##########
@@ -20,16 +20,16 @@
import java.net.URL;
-import org.eclipse.jetty.servlet.DefaultServlet;
+import org.eclipse.jetty.ee10.servlet.DefaultServlet;
import org.eclipse.jetty.util.resource.Resource;
+import org.eclipse.jetty.util.resource.URLResourceFactory;
/**
* Very simple servlet class capable of serving static files.
*/
public class StaticServlet extends DefaultServlet {
private static final long serialVersionUID = 1L;
- @Override
Review Comment:
I believe this is wrong.
The old purpose of the old `Default.getResource(String)` is to serve the
static files.
Now it seems this method is removed in Jetty 12.x and something else should
be used to serve the static files. Instead of removing the `@Override` we need
to replace this method with whatever is the new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
