andrewlamb-est commented on code in PR #3542: URL: https://github.com/apache/avro/pull/3542#discussion_r2490976689
########## lang/java/ipc-jetty/src/main/java/org/apache/avro/ipc/jetty/StatsServer.java: ########## Review Comment: Thanks again for your comments. In relation to the first comment, good spot, and I think you're right. If continuing with ServletHandlers, this change should be made. Without doing this, it may cause a "java.lang.IllegalStateException: Cannot use ServletHandler without ServletContextHandler" as was highlighted by tests for HttpServer before I made the changes in that class. In relation to your second comment, I can look into removing/replacing the relevant ServletHandlers with ServletContextHandlers if you think that is the preferred approach here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
