Kriskras99 commented on issue #383:
URL: https://github.com/apache/avro-rs/issues/383#issuecomment-3719183628

   I think the issue you found with resolving `Long` to `Int`, is a valid 
issue. The code uses an `as` cast instead of a `try_from` and therefore 
silently truncates values. 
   The fact that resolving is more lenient than allowed by the specification is 
also a valid concern, but is not something I think needs to be fixed.
   
   I think your suggested improvement are not usable. They are all severely 
breaking changes and I think they are not an improvement.
   
   If you want resolving that matches the specification, use 
[`SchemaCompatiblity`](https://docs.rs/apache-avro/latest/apache_avro/schema_compatibility/struct.SchemaCompatibility.html)
 to check compatiblity before resolving. `CompleteValue`/`TypedValue` are also 
something you can create yourself while reading values from the reader.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to