martin-g commented on issue #383: URL: https://github.com/apache/avro-rs/issues/383#issuecomment-3737186650
> * Get rid of Value::Union. In my opinion, a union is a schema-level construct describing possible types; a concrete value inhabits a specific branch, not the union itself > * Rename Value::Enum as Value::EnumVariant. Enum is the type, variant is the value. https://github.com/apache/avro-rs/blob/6fc1f96e2a10bf707a5a601d9f6a5e9d988ef27e/avro/src/types.rs#L75-L88 It is kind of the case already - we just have a `u32` index of the variant as an extra information. About `Enum` be renamed to `EnumVariant` - I agree it would have been a more correct name, but I also agree with @Kriskras99 that it is not worth the troubles renaming it now. The crate is still v0.x but we try to keep the API breaks as less as possible! > * Values of named types (Record, Fixed, Enum) should allow an optional name. If no name is provided, resolution is essentially the same structural resolution we have now. If a name is provided, we first perform resolution by name, and if that succeeds, perform structural resolution. @KitFieldhouse Would that make something possible that is currently impossible/broken ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
