[ https://issues.apache.org/jira/browse/BEAM-5790?focusedWorklogId=163373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163373 ]
ASF GitHub Bot logged work on BEAM-5790: ---------------------------------------- Author: ASF GitHub Bot Created on: 07/Nov/18 08:01 Start Date: 07/Nov/18 08:01 Worklog Time Spent: 10m Work Description: je-ik commented on a change in pull request #6750: [BEAM-5790] Euphoria: Remove Dataset abstraction. URL: https://github.com/apache/beam/pull/6750#discussion_r231408194 ########## File path: sdks/java/extensions/euphoria/src/test/java/org/apache/beam/sdk/extensions/euphoria/core/testkit/ReduceByKeyTest.java ########## @@ -146,9 +146,9 @@ public void testReductionType0_outputValues() { // } // // @Override - // protected Dataset<List<KV<Integer, List<Integer>>>> getOutput(Dataset<Integer> + // protected PCollection<List<KV<Integer, List<Integer>>>> getOutput(PCollection<Integer> // input) { - // Dataset<KV<Integer, List<Integer>>> reducedByWindow = + // PCollection<KV<Integer, List<Integer>>> reducedByWindow = // ReduceByKey.of(input) // .keyBy(e -> e % 2) // .valueBy(e -> e) Review comment: I'd suggest removing this commented block of code or at least add explanation why it is commented. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 163373) Time Spent: 1h (was: 50m) > Euphoria: Remove Dataset abstraction > ------------------------------------ > > Key: BEAM-5790 > URL: https://issues.apache.org/jira/browse/BEAM-5790 > Project: Beam > Issue Type: Sub-task > Components: dsl-euphoria > Affects Versions: Not applicable > Reporter: David Moravek > Assignee: David Moravek > Priority: Major > Fix For: 2.9.0 > > Time Spent: 1h > Remaining Estimate: 0h > > There is no point of having Dataset abstraction anymore. We can use > PCollections directly and provide more seamless experience to the end user. > Euphoria did not yet make it to any release, so this is probably the last > chance to get rid of the Dataset abstraction, because this would introduce a > huge breaking change. -- This message was sent by Atlassian JIRA (v7.6.3#76005)