[
https://issues.apache.org/jira/browse/BEAM-5790?focusedWorklogId=164415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-164415
]
ASF GitHub Bot logged work on BEAM-5790:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Nov/18 16:55
Start Date: 09/Nov/18 16:55
Worklog Time Spent: 10m
Work Description: dmvk commented on a change in pull request #6750:
[BEAM-5790] Euphoria: Remove Dataset abstraction.
URL: https://github.com/apache/beam/pull/6750#discussion_r232321981
##########
File path:
sdks/java/extensions/euphoria/src/test/java/org/apache/beam/sdk/extensions/euphoria/core/translate/EuphoriaTest.java
##########
@@ -1,103 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-package org.apache.beam.sdk.extensions.euphoria.core.translate;
-
-import java.io.Serializable;
-import java.util.Arrays;
-import java.util.List;
-import org.apache.beam.sdk.extensions.euphoria.core.client.dataset.Dataset;
-import org.apache.beam.sdk.extensions.euphoria.core.client.lib.Euphoria;
-import org.apache.beam.sdk.extensions.euphoria.core.client.operator.CountByKey;
-import
org.apache.beam.sdk.extensions.euphoria.core.client.operator.MapElements;
-import org.apache.beam.sdk.extensions.kryo.KryoCoder;
-import org.apache.beam.sdk.testing.PAssert;
-import org.apache.beam.sdk.testing.TestPipeline;
-import org.apache.beam.sdk.transforms.Create;
-import org.apache.beam.sdk.values.KV;
-import org.apache.beam.sdk.values.PCollection;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-
-/** A group of test focused at {@link Euphoria}. */
-public class EuphoriaTest implements Serializable {
Review comment:
This test was for the Euphoria PTransform -> `PTransform<Dataset<In>,
Dataset<Out>>`, that was removed by this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 164415)
Time Spent: 1h 40m (was: 1.5h)
> Euphoria: Remove Dataset abstraction
> ------------------------------------
>
> Key: BEAM-5790
> URL: https://issues.apache.org/jira/browse/BEAM-5790
> Project: Beam
> Issue Type: Sub-task
> Components: dsl-euphoria
> Affects Versions: Not applicable
> Reporter: David Moravek
> Assignee: David Moravek
> Priority: Major
> Fix For: 2.9.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> There is no point of having Dataset abstraction anymore. We can use
> PCollections directly and provide more seamless experience to the end user.
> Euphoria did not yet make it to any release, so this is probably the last
> chance to get rid of the Dataset abstraction, because this would introduce a
> huge breaking change.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
