[
https://issues.apache.org/jira/browse/BEAM-6058?focusedWorklogId=166191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166191
]
ASF GitHub Bot logged work on BEAM-6058:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 23:52
Start Date: 14/Nov/18 23:52
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7042:
[BEAM-6058] Publish gRPC 1.13.1 as a vendored dependency.
URL: https://github.com/apache/beam/pull/7042#discussion_r233662673
##########
File path: vendor/grpc-1_13_1/build.gradle
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.apache.beam.gradle.GrpcVendoring
+
+apply plugin: org.apache.beam.gradle.VendorJavaPlugin
+
+description = "Apache Beam :: Vendored Dependencies :: gRPC :: 1.13.1"
+
+group = "org.apache.beam"
+version = "0.1"
Review comment:
Can you document how the versioning of this artifact should be maintained? I
suspect the rules are something like:
- The version embedded in the vendored artifact ID should match exactly the
version of vendored library (`1.13.1`). Upgrading the version of vendored
library should trigger a change in the artifact name.
- Vendored artifact versioning starts at `0.1` and is decoupled from Beam
releases and version numbers
- Increment the vendored artifact version revision only if we need to
release a new version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166191)
Time Spent: 3h 40m (was: 3.5h)
> Support flink config directory for flink runner.
> ------------------------------------------------
>
> Key: BEAM-6058
> URL: https://issues.apache.org/jira/browse/BEAM-6058
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Give user option to use flink configuration from a config directory.
> Earlier we only used jars to submit flink jobs which by default picks the
> cluster flink properties.
> Portability uses remote environment to submit flink job. In Remote
> execution, flink uses the client config instead of the cluster config. This
> require us to submit the custom flink properties via flink client.
> Suggestion is to read the flink config from a flink configuration folder and
> set them to the environment.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
