[
https://issues.apache.org/jira/browse/BEAM-6058?focusedWorklogId=166195&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-166195
]
ASF GitHub Bot logged work on BEAM-6058:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/18 23:52
Start Date: 14/Nov/18 23:52
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #7042:
[BEAM-6058] Publish gRPC 1.13.1 as a vendored dependency.
URL: https://github.com/apache/beam/pull/7042#discussion_r233663231
##########
File path: settings.gradle
##########
@@ -180,8 +180,11 @@ include "beam-sdks-python-container"
project(":beam-sdks-python-container").dir = file("sdks/python/container")
include "beam-sdks-python-container-py3"
project(":beam-sdks-python-container-py3").dir =
file("sdks/python/container/py3")
+// Temporary version that will be deleted once we migrate to using the
published version.
include "beam-vendor-grpc-v1_13_1"
project(":beam-vendor-grpc-v1_13_1").dir = file("vendor/grpc-v1_13_1")
+include "beam-vendor-grpc-1_13_1"
Review comment:
Does the dependency version (`1_13_1`) need to be embedded in the project
name/directory? That means upgrades will include renaming projects and moving a
bunch of files around.
Could we just name it `beam-vendor-grpc`? Presumably only one version should
exist at a time, and we can still embed the version number in the published
artifact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 166195)
Time Spent: 4h (was: 3h 50m)
> Support flink config directory for flink runner.
> ------------------------------------------------
>
> Key: BEAM-6058
> URL: https://issues.apache.org/jira/browse/BEAM-6058
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Give user option to use flink configuration from a config directory.
> Earlier we only used jars to submit flink jobs which by default picks the
> cluster flink properties.
> Portability uses remote environment to submit flink job. In Remote
> execution, flink uses the client config instead of the cluster config. This
> require us to submit the custom flink properties via flink client.
> Suggestion is to read the flink config from a flink configuration folder and
> set them to the environment.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
