[
https://issues.apache.org/jira/browse/BEAM-5959?focusedWorklogId=177933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-177933
]
ASF GitHub Bot logged work on BEAM-5959:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Dec/18 10:36
Start Date: 21/Dec/18 10:36
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #7266:
[BEAM-5959] Add performance testing for writing many files
URL: https://github.com/apache/beam/pull/7266#discussion_r243546157
##########
File path:
sdks/java/testing/test-utils/src/main/java/org/apache/beam/sdk/testutils/NamedTestResult.java
##########
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.testutils;
+
+import com.google.cloud.bigquery.LegacySQLTypeName;
+import com.google.common.collect.ImmutableMap;
+import java.util.Map;
+
+/**
+ * Represents a schema and corresponding test result. Each test may have
multiple named results
+ * published.
+ */
+public class NamedTestResult implements TestResult {
+
+ private final String testID;
+ private final String timestamp;
+ private final String metric;
+ private final long value;
+ private static final Map<String, String> schema =
+ ImmutableMap.<String, String>builder()
+ .put("test_id", LegacySQLTypeName.STRING.name())
+ .put("timestamp", LegacySQLTypeName.TIMESTAMP.name())
+ .put("metric", LegacySQLTypeName.STRING.name())
+ .put("value", LegacySQLTypeName.INTEGER.name())
Review comment:
Sorry for those "scattered" comments but I was doing something similar and
thought of this PR again.
As far as I understand, the idea of `NamedTestResult` is to keep any metrics
in a table with the same schema. is `INTEGER` type enough here? Maybe it's a
good idea to change the type to something future-proof, like `FLOAT`? WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 177933)
Time Spent: 13h 40m (was: 13.5h)
> Add Cloud KMS support to GCS copies
> -----------------------------------
>
> Key: BEAM-5959
> URL: https://issues.apache.org/jira/browse/BEAM-5959
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp, sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Major
> Time Spent: 13h 40m
> Remaining Estimate: 0h
>
> Beam SDK currently uses the CopyTo GCS API call, which doesn't support
> copying objects that Customer Managed Encryption Keys (CMEK).
> CMEKs are managed in Cloud KMS.
> Items (for Java and Python SDKs):
> - Update clients to versions that support KMS keys.
> - Change copyTo API calls to use rewriteTo (Python - directly, Java -
> possibly convert copyTo API call to use client library)
> - Add unit tests.
> - Add basic tests (DirectRunner and GCS buckets with CMEK).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
