[
https://issues.apache.org/jira/browse/BEAM-4454?focusedWorklogId=178026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178026
]
ASF GitHub Bot logged work on BEAM-4454:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Dec/18 15:56
Start Date: 21/Dec/18 15:56
Worklog Time Spent: 10m
Work Description: kanterov commented on a change in pull request #7290:
[[BEAM-4454] Support avro schema inference in sources
URL: https://github.com/apache/beam/pull/7290#discussion_r243600844
##########
File path:
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubIOTest.java
##########
@@ -248,4 +275,170 @@ public void testPrimitiveWriteDisplayData() {
displayData,
hasItem(hasDisplayItem("topic")));
}
+
+ static class GenericClass {
+ int intField;
+ String stringField;
+
+ public GenericClass() {}
+
+ public GenericClass(int intField, String stringField) {
+ this.intField = intField;
+ this.stringField = stringField;
+ }
+
+ @Override
+ public String toString() {
+ return MoreObjects.toStringHelper(getClass())
+ .add("intField", intField)
+ .add("stringField", stringField)
+ .toString();
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(intField, stringField);
+ }
+
+ @Override
+ public boolean equals(Object other) {
+ if (other == null || !(other instanceof GenericClass)) {
+ return false;
+ }
+ GenericClass o = (GenericClass) other;
+ return Objects.equals(intField, o.intField) &&
Objects.equals(stringField, o.stringField);
+ }
+ }
+
+ private transient PipelineOptions options;
+ private static final SubscriptionPath SUBSCRIPTION =
+ PubsubClient.subscriptionPathFromName("test-project",
"testSubscription");
+ private static final Clock CLOCK = (Clock & Serializable) () -> 673L;
+ @Rule public transient TestPipeline readPipeline = TestPipeline.create();
Review comment:
As I understand, `Rule` isn't needed anymore because `setupPipeline` will do
it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 178026)
Time Spent: 11.5h (was: 11h 20m)
> Provide automatic schema registration for AVROs
> -----------------------------------------------
>
> Key: BEAM-4454
> URL: https://issues.apache.org/jira/browse/BEAM-4454
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> Need to make sure this is a compatible change
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
