[ https://issues.apache.org/jira/browse/BEAM-4454?focusedWorklogId=178268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-178268 ]
ASF GitHub Bot logged work on BEAM-4454: ---------------------------------------- Author: ASF GitHub Bot Created on: 22/Dec/18 16:19 Start Date: 22/Dec/18 16:19 Worklog Time Spent: 10m Work Description: reuvenlax commented on a change in pull request #7290: [[BEAM-4454] Support avro schema inference in sources URL: https://github.com/apache/beam/pull/7290#discussion_r243740549 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java ########## @@ -251,6 +252,35 @@ public static GenericRecord toGenericRecord( return builder.build(); } + @SuppressWarnings("unchecked") + public static <T> SerializableFunction<T, Row> getToRowFunction( + Class<T> clazz, @Nullable org.apache.avro.Schema schema) { + if (GenericRecord.class.equals(clazz)) { + Schema beamSchema = toBeamSchema(schema); + return (SerializableFunction<T, Row>) getGenericRecordToRowFunction(beamSchema); + } else { + return new AvroRecordSchema().toRowFunction(TypeDescriptor.of(clazz)); + } + } + + @SuppressWarnings("unchecked") + public static <T> SerializableFunction<Row, T> getFromRowFunction(Class<T> clazz) { + return (GenericRecord.class.equals(clazz)) + ? (SerializableFunction<Row, T>) getRowToGenericRecordFunction(null) + : new AvroRecordSchema().fromRowFunction(TypeDescriptor.of(clazz)); + } + + @Nullable + public static <T> Schema getSchema(Class<T> clazz, @Nullable org.apache.avro.Schema schema) { Review comment: true... I was trying to avoid duplicating this code between AvroIO and PubSubIO. Let me think on this a bit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 178268) Time Spent: 12.5h (was: 12h 20m) > Provide automatic schema registration for AVROs > ----------------------------------------------- > > Key: BEAM-4454 > URL: https://issues.apache.org/jira/browse/BEAM-4454 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-core > Reporter: Reuven Lax > Assignee: Reuven Lax > Priority: Major > Time Spent: 12.5h > Remaining Estimate: 0h > > Need to make sure this is a compatible change -- This message was sent by Atlassian JIRA (v7.6.3#76005)