[ 
https://issues.apache.org/jira/browse/BEAM-10136?focusedWorklogId=456969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-456969
 ]

ASF GitHub Bot logged work on BEAM-10136:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jul/20 04:07
            Start Date: 10/Jul/20 04:07
    Worklog Time Spent: 10m 
      Work Description: piotr-szuberski commented on a change in pull request 
#12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r452611468



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1982,17 +1982,25 @@ class BeamModulePlugin implements Plugin<Project> {
         return argList.join(' ')
       }
 
-      project.ext.toxTask = { name, tox_env ->
+      project.ext.toxTask = { name, tox_env, needsExpansionServiceJar = true ->

Review comment:
       Yeah, definitely. I made it true as default without thinking at the 
moment of writing it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 456969)
    Time Spent: 14h  (was: 13h 50m)

> Add cross-language wrapper for Java's JdbcIO Write
> --------------------------------------------------
>
>                 Key: BEAM-10136
>                 URL: https://issues.apache.org/jira/browse/BEAM-10136
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>    Affects Versions: Not applicable
>            Reporter: Piotr Szuberski
>            Assignee: Piotr Szuberski
>            Priority: P2
>              Labels: portability
>             Fix For: Not applicable
>
>          Time Spent: 14h
>  Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's Jdbc Write



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to