[
https://issues.apache.org/jira/browse/BEAM-10136?focusedWorklogId=457206&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-457206
]
ASF GitHub Bot logged work on BEAM-10136:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/20 15:40
Start Date: 10/Jul/20 15:40
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12145:
URL: https://github.com/apache/beam/pull/12145#discussion_r452918966
##########
File path: sdks/java/io/expansion-service/build.gradle
##########
@@ -33,6 +33,8 @@ ext.summary = "Expansion service serving several Java IOs"
dependencies {
compile project(":sdks:java:expansion-service")
compile project(":sdks:java:io:kafka")
+ runtime project(":sdks:java:io:jdbc")
runtime library.java.kafka_clients
+ runtime library.java.postgres
Review comment:
nit: It might not be clear why this is here
```suggestion
// Include postgres so it can be used with external JDBC
runtime library.java.postgres
```
##########
File path: CHANGES.md
##########
@@ -55,6 +55,8 @@
* New overloads for BigtableIO.Read.withKeyRange() and
BigtableIO.Read.withRowFilter()
methods that take ValueProvider as a parameter (Java)
([BEAM-10283](https://issues.apache.org/jira/browse/BEAM-10283)).
+* Add cross-language support to
JdbcIO.ReadRows([BEAM-10135](https://issues.apache.org/jira/browse/BEAM-10135)).
+* Add cross-language support to
JdbcIO.Write([BEAM-10136](https://issues.apache.org/jira/browse/BEAM-10136)).
Review comment:
```suggestion
* Add cross-language support to Java's JdbcIO, now available in the Python
module `apache_beam.io.external.jdbc`
([BEAM-10135](https://issues.apache.org/jira/browse/BEAM-10135),
[BEAM-10136](https://issues.apache.org/jira/browse/BEAM-10136)).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 457206)
Time Spent: 15.5h (was: 15h 20m)
> Add cross-language wrapper for Java's JdbcIO Write
> --------------------------------------------------
>
> Key: BEAM-10136
> URL: https://issues.apache.org/jira/browse/BEAM-10136
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Affects Versions: Not applicable
> Reporter: Piotr Szuberski
> Assignee: Piotr Szuberski
> Priority: P2
> Labels: portability
> Fix For: Not applicable
>
> Time Spent: 15.5h
> Remaining Estimate: 0h
>
> Add cross-language wrapper for Java's Jdbc Write
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
