[ https://issues.apache.org/jira/browse/BEAM-5953?focusedWorklogId=185966&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185966 ]
ASF GitHub Bot logged work on BEAM-5953: ---------------------------------------- Author: ASF GitHub Bot Created on: 16/Jan/19 20:04 Start Date: 16/Jan/19 20:04 Worklog Time Spent: 10m Work Description: markflyhigh commented on pull request #7521: [BEAM-5953] Fix py3 type error in bundle_processor URL: https://github.com/apache/beam/pull/7521#discussion_r248431715 ########## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ########## @@ -590,9 +590,11 @@ def get_coder(self, coder_id): if coder_proto.spec.spec.urn: return self.context.coders.get_by_id(coder_id) else: + payload = coder_proto.spec.spec.payload + if isinstance(payload, bytes): Review comment: Since this decoding is only needed in python 3, I prefer to add version check here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 185966) Time Spent: 2h 40m (was: 2.5h) > Support DataflowRunner on Python 3 > ---------------------------------- > > Key: BEAM-5953 > URL: https://issues.apache.org/jira/browse/BEAM-5953 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Mark Liu > Assignee: Mark Liu > Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)