[
https://issues.apache.org/jira/browse/BEAM-5953?focusedWorklogId=185997&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-185997
]
ASF GitHub Bot logged work on BEAM-5953:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/19 21:22
Start Date: 16/Jan/19 21:22
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #7521: [BEAM-5953]
Fix py3 type error in bundle_processor
URL: https://github.com/apache/beam/pull/7521#discussion_r248455123
##########
File path: sdks/python/apache_beam/runners/worker/operation_specs.py
##########
@@ -354,7 +354,10 @@ def get_coder_from_spec(coder_spec):
# We pass coders in the form "<coder_name>$<pickled_data>" to make the job
# description JSON more readable.
- return coders.coders.deserialize_coder(coder_spec['@type'])
+ coder = coder_spec['@type']
+ if not isinstance(coder, bytes):
Review comment:
Do we understand in which codepath we happen to populate coders_spec
without encoding it to bytes? If so, can we encode at the creation time? I
think it would be easier to reason about SDK internals if we can state that
this method always expects the same datatype (a bytestring) as input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 185997)
Time Spent: 3h 10m (was: 3h)
> Support DataflowRunner on Python 3
> ----------------------------------
>
> Key: BEAM-5953
> URL: https://issues.apache.org/jira/browse/BEAM-5953
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
