[
https://issues.apache.org/jira/browse/BEAM-10703?focusedWorklogId=474417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474417
]
ASF GitHub Bot logged work on BEAM-10703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/20 17:37
Start Date: 25/Aug/20 17:37
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476618504
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -1264,6 +1268,10 @@ private static void translateFn(
// in streaming but does not work in batch
if (context.getPipelineOptions().isStreaming() && isStateful) {
stepContext.addInput(PropertyNames.USES_KEYED_STATE, "true");
Review comment:
Is `ALLOWS_SHARDABLE_STATE ` supported by both streaming engine and
windmill appliance? If it's only for streaming engine, is it safe to populate
this field for both?
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##########
@@ -100,8 +99,7 @@ public long getBatchSize() {
ParDo.of(new GroupIntoBatchesDoFn<>(batchSize, allowedLateness,
keyCoder, valueCoder)));
}
- @VisibleForTesting
- static class GroupIntoBatchesDoFn<K, InputT>
+ public static class GroupIntoBatchesDoFn<K, InputT>
Review comment:
I don't think we want to make `GroupInToBatchesDoFn` as `public`.
Instead of adding property in `translateFn `, we can do it at transform level,
where you can check `transform instanceof GroupIntoBatches`, for example:
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java#L752
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 474417)
Time Spent: 4h 10m (was: 4h)
> Add support for auto-sharded GroupIntoBatches in Dataflow runner
> ----------------------------------------------------------------
>
> Key: BEAM-10703
> URL: https://issues.apache.org/jira/browse/BEAM-10703
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P2
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> The proposal of improving GroupIntoBatches transform is in BEAM-10475
> This tracks the support in Cloud Dataflow Runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
