[
https://issues.apache.org/jira/browse/BEAM-10703?focusedWorklogId=474602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-474602
]
ASF GitHub Bot logged work on BEAM-10703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/20 02:27
Start Date: 26/Aug/20 02:27
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #12678:
URL: https://github.com/apache/beam/pull/12678#discussion_r476991127
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##########
@@ -100,8 +99,7 @@ public long getBatchSize() {
ParDo.of(new GroupIntoBatchesDoFn<>(batchSize, allowedLateness,
keyCoder, valueCoder)));
}
- @VisibleForTesting
- static class GroupIntoBatchesDoFn<K, InputT>
+ public static class GroupIntoBatchesDoFn<K, InputT>
Review comment:
I was thinking about we could check `GroupIntoBatches` directly but it
turns out that the translation happens after transform expansions, where we
only can get `ParDo(GroupIntoBatchesDoFn)`. One thing we can do to avoid
exposing `GroupIntoBatchesDoFn` is to make `DoFnSignature` understand that this
is a `shardable stateful DoFn`, like what we do for `RESTRICTION_ENCODING`.
@lukecwik Do you have any suggestion here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 474602)
Time Spent: 5h 10m (was: 5h)
> Add support for auto-sharded GroupIntoBatches in Dataflow runner
> ----------------------------------------------------------------
>
> Key: BEAM-10703
> URL: https://issues.apache.org/jira/browse/BEAM-10703
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P2
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> The proposal of improving GroupIntoBatches transform is in BEAM-10475
> This tracks the support in Cloud Dataflow Runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
