[
https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=186674&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-186674
]
ASF GitHub Bot logged work on BEAM-4620:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/19 02:22
Start Date: 18/Jan/19 02:22
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #7555:
[BEAM-4620] UnboundedReadFromBoundedSource should invoke split for small sources
URL: https://github.com/apache/beam/pull/7555
**Please** add a meaningful description for your change here
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 186674)
Time Spent: 10m
Remaining Estimate: 0h
> UnboundedReadFromBoundedSource.split() should always call split()
> -----------------------------------------------------------------
>
> Key: BEAM-4620
> URL: https://issues.apache.org/jira/browse/BEAM-4620
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Josh M
> Assignee: Chamikara Jayalath
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If the source contains too little data (rounds the result down to 0), or if
> size estimation fails, then we don't call .split(). We must always call
> split(); instead of returning original source, we should have computed some
> fallback value for desiredBundleSize.
> This bug has existed since the code was first introduced, so it is not a
> regression - but it is certainly a bug.
>
> source:
> https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
