[ https://issues.apache.org/jira/browse/BEAM-4620?focusedWorklogId=191144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191144 ]
ASF GitHub Bot logged work on BEAM-4620: ---------------------------------------- Author: ASF GitHub Bot Created on: 28/Jan/19 17:29 Start Date: 28/Jan/19 17:29 Worklog Time Spent: 10m Work Description: swegner commented on pull request #7633: [BEAM-4620] Updates UnboundedReadFromBoundedSource.split() to at least create one split URL: https://github.com/apache/beam/pull/7633 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 191144) Time Spent: 1h 40m (was: 1.5h) > UnboundedReadFromBoundedSource.split() should always call split() > ----------------------------------------------------------------- > > Key: BEAM-4620 > URL: https://issues.apache.org/jira/browse/BEAM-4620 > Project: Beam > Issue Type: Bug > Components: sdk-java-core > Reporter: Josh M > Assignee: Chamikara Jayalath > Priority: Minor > Fix For: 2.11.0 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > If the source contains too little data (rounds the result down to 0), or if > size estimation fails, then we don't call .split(). We must always call > split(); instead of returning original source, we should have computed some > fallback value for desiredBundleSize. > This bug has existed since the code was first introduced, so it is not a > regression - but it is certainly a bug. > > source: > https://github.com/apache/beam/blob/697a1d17e473cd5b097aaaeee24c08f43cc77f58/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/UnboundedReadFromBoundedSource.java#L137 -- This message was sent by Atlassian JIRA (v7.6.3#76005)