[ https://issues.apache.org/jira/browse/BEAM-6457?focusedWorklogId=188552&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188552 ]
ASF GitHub Bot logged work on BEAM-6457: ---------------------------------------- Author: ASF GitHub Bot Created on: 22/Jan/19 23:57 Start Date: 22/Jan/19 23:57 Worklog Time Spent: 10m Work Description: pabloem commented on pull request #7542: [BEAM-6457] Refactoring of a few BigQuery classes. URL: https://github.com/apache/beam/pull/7542#discussion_r250008609 ########## File path: sdks/python/apache_beam/io/gcp/bigquery.py ########## @@ -165,38 +148,6 @@ 'WriteToBigQuery', ] -JSON_COMPLIANCE_ERROR = 'NAN, INF and -INF values are not JSON compliant.' -MAX_RETRIES = 3 - - -def default_encoder(obj): - if isinstance(obj, decimal.Decimal): - return str(obj) - raise TypeError( - "Object of type '%s' is not JSON serializable" % type(obj).__name__) - - -class RowAsDictJsonCoder(coders.Coder): Review comment: I made sure to avoid moving any methods defined in `__all__`. Isn't `__all__` a reasonable implicit include/exclude of backward compatibility guarantees? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 188552) Time Spent: 2h (was: 1h 50m) > bigquery.py is too large, and some tools are better moved elsewhere > ------------------------------------------------------------------- > > Key: BEAM-6457 > URL: https://issues.apache.org/jira/browse/BEAM-6457 > Project: Beam > Issue Type: Bug > Components: sdk-py-core > Reporter: Pablo Estrada > Assignee: Pablo Estrada > Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Need to do a bit of refactoring of that file -- This message was sent by Atlassian JIRA (v7.6.3#76005)