[
https://issues.apache.org/jira/browse/BEAM-6269?focusedWorklogId=188968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-188968
]
ASF GitHub Bot logged work on BEAM-6269:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jan/19 14:05
Start Date: 23/Jan/19 14:05
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7316: [BEAM-6269]
Cross-SDK transform expansion protocol.
URL: https://github.com/apache/beam/pull/7316#discussion_r250185036
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SdkComponents.java
##########
@@ -239,10 +273,10 @@ public String getOnlyEnvironmentId() {
}
private String uniqify(String baseName, Set<String> existing) {
- String name = baseName;
+ String name = namespace + baseName;
Review comment:
We can't really preserve structure here, as these will be string ids (and as
well as being a huge rewrite, maps with non-primitive keys are painful to
dealwith). Also, namespaces may be hierarchical (on both sides) so we don't
want to introduce escaping (at least not on the LHS).
Namespace is nothing more than a required prefix; I'll document that better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 188968)
Time Spent: 3.5h (was: 3h 20m)
> Support mixed-language pipelines.
> ---------------------------------
>
> Key: BEAM-6269
> URL: https://issues.apache.org/jira/browse/BEAM-6269
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, runner-core, sdk-java-core, sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
