[
https://issues.apache.org/jira/browse/BEAM-6269?focusedWorklogId=191067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191067
]
ASF GitHub Bot logged work on BEAM-6269:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 15:29
Start Date: 28/Jan/19 15:29
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #7316:
[BEAM-6269] Cross-SDK transform expansion protocol.
URL: https://github.com/apache/beam/pull/7316#discussion_r251461833
##########
File path: sdks/python/apache_beam/runners/pipeline_context.py
##########
@@ -89,6 +93,18 @@ def get_by_id(self, id):
self._id_to_proto[id], self._pipeline_context)
return self._id_to_obj[id]
+ def get_by_proto(self, maybe_new_proto, label=None, deduplicate=False):
+ if deduplicate:
Review comment:
Add a test to pipeline_context_test.py to cover this path ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 191067)
Time Spent: 4h 10m (was: 4h)
> Support mixed-language pipelines.
> ---------------------------------
>
> Key: BEAM-6269
> URL: https://issues.apache.org/jira/browse/BEAM-6269
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, runner-core, sdk-java-core, sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
