[ https://issues.apache.org/jira/browse/BEAM-6361?focusedWorklogId=189210&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189210 ]
ASF GitHub Bot logged work on BEAM-6361: ---------------------------------------- Author: ASF GitHub Bot Created on: 23/Jan/19 22:28 Start Date: 23/Jan/19 22:28 Worklog Time Spent: 10m Work Description: mxm commented on pull request #7408: [BEAM-6361][BEAM-6364] fix user-metric-prefix checking in Flink portable metrics update URL: https://github.com/apache/beam/pull/7408#discussion_r250397401 ########## File path: runners/flink/src/test/java/org/apache/beam/runners/flink/metrics/FlinkMetricContainerTest.java ########## @@ -106,6 +110,39 @@ public void testGauge() { assertThat(flinkGauge.getValue().getValue(), is(42L)); } + @Test + public void testMonitoringInfoUpdate() { + FlinkMetricContainer container = new FlinkMetricContainer(runtimeContext); + MetricsContainer step = container.getMetricsContainer("step"); + + SimpleCounter userCounter = new SimpleCounter(); + when(metricGroup.counter("ns1.metric1")).thenReturn(userCounter); + + SimpleCounter elemCounter = new SimpleCounter(); + when(metricGroup.counter("beam.metric:element_count:v1")).thenReturn(elemCounter); Review comment: I suppose user-defined counters should not be able to change the namespace via colons. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 189210) Time Spent: 1h 50m (was: 1h 40m) > Fix user-metric prefix detection for portable Flink metrics > ----------------------------------------------------------- > > Key: BEAM-6361 > URL: https://issues.apache.org/jira/browse/BEAM-6361 > Project: Beam > Issue Type: Bug > Components: runner-flink > Affects Versions: 2.9.0 > Reporter: Ryan Williams > Assignee: Ryan Williams > Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > [~ajam...@google.com] [noticed a > bug|https://github.com/apache/beam/pull/7183/files#r243402155] in classifying > portable Flink metrics as user-namespaced vs not. > I think it's only currently affecting how metrics get displayed downstream in > Flink, but it should be fixed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)