[
https://issues.apache.org/jira/browse/BEAM-6361?focusedWorklogId=189726&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-189726
]
ASF GitHub Bot logged work on BEAM-6361:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/19 22:59
Start Date: 24/Jan/19 22:59
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7408:
[BEAM-6361][BEAM-6364] fix user-metric-prefix checking in Flink portable
metrics update
URL: https://github.com/apache/beam/pull/7408#discussion_r250810281
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/metrics/SimpleMonitoringInfoBuilder.java
##########
@@ -112,7 +112,7 @@ private boolean validate() {
if (split.size() != 5) {
LOG.warn(
"Dropping MonitoringInfo for URN {}, UserMetric namespaces and "
- + "name cannot contain ':' characters.",
+ + "names cannot contain ':' characters.",
Review comment:
It seems like you're agreeing that my fix is better? I'd changed it from
"namespaces and name" to "namespaces and names".
I also agree about the `s/,/./` on the comma.
However it seems like this whole warning was dropped in the meantime, so
this is all moot!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 189726)
Time Spent: 2h (was: 1h 50m)
> Fix user-metric prefix detection for portable Flink metrics
> -----------------------------------------------------------
>
> Key: BEAM-6361
> URL: https://issues.apache.org/jira/browse/BEAM-6361
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.9.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> [~ajam...@google.com] [noticed a
> bug|https://github.com/apache/beam/pull/7183/files#r243402155] in classifying
> portable Flink metrics as user-namespaced vs not.
> I think it's only currently affecting how metrics get displayed downstream in
> Flink, but it should be fixed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
