[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=501200&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-501200
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/20 17:44
Start Date: 15/Oct/20 17:44
Worklog Time Spent: 10m
Work Description: chadrik commented on a change in pull request #13060:
URL: https://github.com/apache/beam/pull/13060#discussion_r505725707
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -62,13 +64,15 @@
from apache_beam.runners.portability.fn_api_runner.translations import
only_element
from apache_beam.runners.portability.fn_api_runner.worker_handlers import
WorkerHandlerManager
from apache_beam.transforms import environments
-from apache_beam.utils import profiler
from apache_beam.utils import proto_utils
from apache_beam.utils import thread_pool_executor
+from apache_beam.utils.profiler import Profile
Review comment:
I changed this import because `profiler` was conflicting with some local
variable names, and this was the simplest resolution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 501200)
Time Spent: 111.5h (was: 111h 20m)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 111.5h
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
