[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=501203&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-501203
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/20 17:49
Start Date: 15/Oct/20 17:49
Worklog Time Spent: 10m
Work Description: chadrik commented on a change in pull request #13060:
URL: https://github.com/apache/beam/pull/13060#discussion_r505725952
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -539,6 +548,7 @@ def merge_results(last_result):
else:
data_input = deferred_inputs
input_timers = fired_timers
+ # FIXME: this seems unused, and produces an attr-defined error
bundle_manager._registered = True
Review comment:
Can I safely get rid of this attribute?
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##########
@@ -307,6 +308,9 @@ def executable_stage_transform(
for side in side_inputs
},
main_input=main_input_id)
+ # at this point we should have resolved an environment, as the key of
+ # components.environments cannot be None.
+ assert self.environment is not None
Review comment:
We discussed this before and said this was safe, but just wanted to
double check.
##########
File path: sdks/python/apache_beam/utils/profiler.py
##########
@@ -113,7 +116,10 @@ def __exit__(self, *args):
h = self.hpy.heap()
heap_dump_data = '%s\n%s' % (h, h.more)
self._upload_profile_data(
- 'memory_profile', heap_dump_data, write_binary=False)
+ self.profile_location,
+ 'memory_profile',
+ heap_dump_data,
+ write_binary=False)
Review comment:
I decided to change this to pass in `self.profile_location` because in
this context, where it's called, we know that it's not `None`. Let's us avoid
calling `assert` inside `self._upload_profile_data`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 501203)
Time Spent: 111h 40m (was: 111.5h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Priority: P3
> Time Spent: 111h 40m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
