[
https://issues.apache.org/jira/browse/BEAM-6431?focusedWorklogId=194364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194364
]
ASF GitHub Bot logged work on BEAM-6431:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/19 02:40
Start Date: 05/Feb/19 02:40
Worklog Time Spent: 10m
Work Description: ajamato commented on issue #7676: DO NOT SUBMIT
[BEAM-6431] Implement Execution Time metrics start,process,finish in the Java
SDK
URL: https://github.com/apache/beam/pull/7676#issuecomment-460492867
@ryan-williams @Ardagan
https://github.com/apache/beam/pull/7676
This PR is ready for review now. Uses the ExecutionStateTracker in the Java
SDK to collect PTransformExecutionTimeRegistry.
I also started using matches for testing MonitoringInfos, we can add more
matchers over time, this eliminates the need to cleanup/clear timestamps,
values, etc when testing monitoring infos.
The usage of the states and state tracker mostly happen inside the
PCollectionConsumerRegistry and PTransformFunctionRegistry. Once again I have
changed its signature and ctors, which affects many tests which are using them
(due to the repeated patterns in tests)
PTAL and let me know what you think of these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 194364)
Time Spent: 2h 10m (was: 2h)
> Add ExecutionTime metrics to the Beam Java SDK
> ----------------------------------------------
>
> Key: BEAM-6431
> URL: https://issues.apache.org/jira/browse/BEAM-6431
> Project: Beam
> Issue Type: New Feature
> Components: java-fn-execution
> Reporter: Alex Amato
> Assignee: Alex Amato
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> This will be done by using the Dataflow worker's StateSampler code. I have
> put together a refactoring plan
> [here|https://docs.google.com/document/d/1OlAJf4T_CTL9WRH8lP8uQOfLjWYfm8IpRXSe38g34k4/edit#]
> This will include estimating the processing time for the start, process and
> finish bundle. The python SDK already has an implementation of this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
