[ https://issues.apache.org/jira/browse/BEAM-6431?focusedWorklogId=194656&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194656 ]
ASF GitHub Bot logged work on BEAM-6431: ---------------------------------------- Author: ASF GitHub Bot Created on: 05/Feb/19 16:35 Start Date: 05/Feb/19 16:35 Worklog Time Spent: 10m Work Description: Ardagan commented on pull request #7676: DO NOT SUBMIT [BEAM-6431] Implement Execution Time metrics start,process,finish in the Java SDK URL: https://github.com/apache/beam/pull/7676#discussion_r253941309 ########## File path: runners/java-fn-execution/src/test/java/org/apache/beam/runners/fnexecution/control/RemoteExecutionTest.java ########## @@ -510,30 +514,33 @@ public void testMetrics() throws Exception { ParDo.of( new DoFn<byte[], String>() { private boolean emitted = false; - Counter startCounter = + private Counter startCounter = Metrics.counter(RemoteExecutionTest.class, startUserCounterName); @StartBundle public void startBundle() throws InterruptedException { + Thread.sleep(1000); Review comment: any way for us to use smaller values here, or avoid Thread.sleep at all? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 194656) Time Spent: 2.5h (was: 2h 20m) > Add ExecutionTime metrics to the Beam Java SDK > ---------------------------------------------- > > Key: BEAM-6431 > URL: https://issues.apache.org/jira/browse/BEAM-6431 > Project: Beam > Issue Type: New Feature > Components: java-fn-execution > Reporter: Alex Amato > Assignee: Alex Amato > Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > This will be done by using the Dataflow worker's StateSampler code. I haveĀ > put together a refactoring plan > [here|https://docs.google.com/document/d/1OlAJf4T_CTL9WRH8lP8uQOfLjWYfm8IpRXSe38g34k4/edit#] > This will include estimating the processing time for the start, process and > finish bundle. The python SDK already has an implementation of this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)