[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=536569&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-536569
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jan/21 18:01
Start Date: 15/Jan/21 18:01
Worklog Time Spent: 10m
Work Description: tysonjh commented on a change in pull request #13669:
URL: https://github.com/apache/beam/pull/13669#discussion_r558474683
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
Review comment:
This is a lower version than `$checkerframework_version`, is there a
reason?
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.mortbay.jetty:jetty-util:6.1.26"
+ compile library.java.slf4j_api
Review comment:
Move this up with the other `library.` definitions.
##########
File path: runners/twister2/build.gradle
##########
@@ -36,7 +36,22 @@ dependencies {
compile (project(path: ":runners:core-java")){
exclude group: 'com.esotericsoftware.kryo', module: 'kryo'
}
- compile project(":runners:java-fn-execution")
+ compile project(path: ":model:pipeline", configuration: "shadow")
+ compile project(path: ":runners:core-construction-java")
+ compile project(path: ":sdks:java:core", configuration: "shadow")
+ compile library.java.jackson_annotations
+ compile library.java.joda_time
+ compile library.java.vendored_grpc_1_26_0
+ compile "org.checkerframework:checker-qual:2.0.0"
+ compile "org.mortbay.jetty:jetty-util:6.1.26"
+ compile library.java.slf4j_api
+ compile "org.twister2:comms-api-java:0.6.0"
Review comment:
Use `$twister2_version` throughout.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 536569)
Time Spent: 53h 50m (was: 53h 40m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 53h 50m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
