[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=536578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-536578
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jan/21 18:19
Start Date: 15/Jan/21 18:19
Worklog Time Spent: 10m
Work Description: tysonjh commented on a change in pull request #13649:
URL: https://github.com/apache/beam/pull/13649#discussion_r558487143
##########
File path: examples/java/build.gradle
##########
@@ -73,7 +73,17 @@ dependencies {
compile library.java.joda_time
compile library.java.proto_google_cloud_datastore_v1
compile library.java.slf4j_api
- compile library.java.slf4j_jdk14
+ compile "com.google.api.grpc:proto-google-cloud-language-v1:1.81.4"
+ compile ("io.confluent:kafka-avro-serializer:5.3.2") {
+ // It depends on "spotbugs-annotations:3.1.9" which clashes with current
+ // "spotbugs-annotations:3.1.12" used in Beam. Not required.
+ exclude group: "org.apache.zookeeper", module: "zookeeper"
+ }
+ compile library.java.vendored_guava_26_0_jre
+ compile "org.apache.httpcomponents:httpclient:4.5.13"
+ compile "org.apache.httpcomponents:httpcore:4.4.13"
+ compile library.java.google_oauth_client
+ compile library.java.vendored_grpc_1_26_0
Review comment:
These should be grouped by common prefix, in alphabetical order. E.g.
all `compile library.*` lines should be together, with those above, in
alphabetical order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 536578)
Time Spent: 54h 10m (was: 54h)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 54h 10m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
