[
https://issues.apache.org/jira/browse/BEAM-10961?focusedWorklogId=537953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-537953
]
ASF GitHub Bot logged work on BEAM-10961:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jan/21 18:24
Start Date: 19/Jan/21 18:24
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #13668:
URL: https://github.com/apache/beam/pull/13668#issuecomment-763032905
> > > @sonam-vend and I were thinking we'd likely have only a small-ish
number of issues (hopefully zero or thereabouts!) when we enable the switch at
the global level.
> >
> >
> > @shehzaadn-vd Why hope for zero issues when we could guarantee zero
issues?
> > > Since eventually we'll be turning on the global switch anyway,
enabling strict dependencies at the module level would have to be undone anyway.
> >
> >
> > It's a trivial amount of work to add and remove these settings. The
benefit of gaining strict dependency analysis on each module immediately
outweighs the cost of copy+paste+deleting a few lines in each file.
>
> @ibzib Understood. Let us look into that.
All you need to do is add `enableStrictDependencies: true` as an argument to
`applyJavaNature` in each build.gradle file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 537953)
Time Spent: 55h 50m (was: 55h 40m)
> Enable strict dependency analysis on all Java modules
> ------------------------------------------------------
>
> Key: BEAM-10961
> URL: https://issues.apache.org/jira/browse/BEAM-10961
> Project: Beam
> Issue Type: Improvement
> Components: java-fn-execution
> Reporter: Shehzaad Nakhoda
> Assignee: Shehzaad Nakhoda
> Priority: P2
> Time Spent: 55h 50m
> Remaining Estimate: 0h
>
> This is an IWYU analysis. If the module is using its transitive deps without
> depending on them, or if it has direct dependencies it doesn't use, the build
> fails. The work involves adding dependencies or adding exclusion rules
> (example:
> https://github.com/wfhartford/gradle-dependency-analyze#configurations). Even
> if they just add exclusions across the board, it will be a big win because it
> will prevent new violations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
