[ 
https://issues.apache.org/jira/browse/BEAM-11914?focusedWorklogId=572749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-572749
 ]

ASF GitHub Bot logged work on BEAM-11914:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Mar/21 16:54
            Start Date: 26/Mar/21 16:54
    Worklog Time Spent: 10m 
      Work Description: xinyuiscool commented on pull request #14155:
URL: https://github.com/apache/beam/pull/14155#issuecomment-808369943


   Make sense. I updated the DoFnInvokersTest to verify the setup() will be 
invoked with pipelineOptions by DoFnInvoker, but it doesn't verify from the 
runner side. Let me add a ValidatesRunner test there. Thanks for the suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 572749)
    Time Spent: 3h 20m  (was: 3h 10m)

> Add PipelineOptions as DoFn @Setup parameters
> ---------------------------------------------
>
>                 Key: BEAM-11914
>                 URL: https://issues.apache.org/jira/browse/BEAM-11914
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Xinyu Liu
>            Assignee: Xinyu Liu
>            Priority: P2
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Passing PipelineOptions to DoFn @Setup makes it easier for the users to 
> access their pipeline arguments. It also allows dynamically creating 
> PipelineOptions while constructing the pipeline, and can benefit integration 
> with other config management framework.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to