[
https://issues.apache.org/jira/browse/BEAM-4076?focusedWorklogId=201446&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201446
]
ASF GitHub Bot logged work on BEAM-4076:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 17:05
Start Date: 20/Feb/19 17:05
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7635:
[BEAM-4076] Generalize schema inputs to ParDo
URL: https://github.com/apache/beam/pull/7635#discussion_r258583402
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/ParDoTranslation.java
##########
@@ -161,9 +158,40 @@ public boolean canTranslate(PTransform<?, ?> pTransform) {
}
public static ParDoPayload translateParDo(
- final ParDo.MultiOutput<?, ?> parDo, Pipeline pipeline, SdkComponents
components)
- throws IOException {
+ AppliedPTransform<?, ?, ?> appliedPTransform, SdkComponents components)
throws IOException {
Review comment:
`AppliedPTransform<ParDo.MultiOutput<?, ?>, ? ,?>` or some such? Avoids the
cast below. Might force a cast at the caller, and that makes sense because the
caller is the one who is making the decision to pass the param.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201446)
Time Spent: 19.5h (was: 19h 20m)
> Schema followups
> ----------------
>
> Key: BEAM-4076
> URL: https://issues.apache.org/jira/browse/BEAM-4076
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, dsl-sql, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 19.5h
> Remaining Estimate: 0h
>
> This umbrella bug contains subtasks with followups for Beam schemas, which
> were moved from SQL to the core Java SDK and made to be type-name-based
> rather than coder based.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
