[
https://issues.apache.org/jira/browse/BEAM-4076?focusedWorklogId=201517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201517
]
ASF GitHub Bot logged work on BEAM-4076:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 18:49
Start Date: 20/Feb/19 18:49
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #7635: [BEAM-4076]
Generalize schema inputs to ParDo
URL: https://github.com/apache/beam/pull/7635#discussion_r258625424
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/Cast.java
##########
@@ -300,7 +300,7 @@ public void verifyCompatibility(Schema inputSchema) {
@ProcessElement
public void process(
- @FieldAccess("filterFields") Row input,
OutputReceiver<Row> r) {
+ @FieldAccess("filterFields") @Element Row input,
OutputReceiver<Row> r) {
Review comment:
After this PR, FieldAccess no longer replaces Element. However the next PR
will remove the need for Element (requires more refactoring)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201517)
Time Spent: 20h (was: 19h 50m)
> Schema followups
> ----------------
>
> Key: BEAM-4076
> URL: https://issues.apache.org/jira/browse/BEAM-4076
> Project: Beam
> Issue Type: Improvement
> Components: beam-model, dsl-sql, sdk-java-core
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 20h
> Remaining Estimate: 0h
>
> This umbrella bug contains subtasks with followups for Beam schemas, which
> were moved from SQL to the core Java SDK and made to be type-name-based
> rather than coder based.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
