[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=201522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201522
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/19 18:54
Start Date: 20/Feb/19 18:54
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #7868: [BEAM-4775]
MonitoringInfo URN tweaks
URL: https://github.com/apache/beam/pull/7868#discussion_r258622638
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -337,24 +337,19 @@ message Annotation {
// MonitoringInfo protos.
message MonitoringInfoSpecs {
enum Enum {
- // TODO(ajamato): Add the PTRANSFORM name as a required label after
Review comment:
My take on this:
1. It is better ot keep this spec present. It defines what fields user
counter needs.
2. We can rename this element to something like USER_COUNTER_PREFIX for
clarity.
3. It is ok to move it away from this list, but we should still keep it
somewhere for generic validation and specification. However in this case we
might want to move it away from MonitoringInfoUrns as well.
4. Currently, we have urns defined in this list and in MonitoringInfoUrns. I
was thinking of removing MonitoringInfoUrns completely and keep only
MonitoringInfoSpecs as explicit source of truth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201522)
Time Spent: 17h 40m (was: 17.5h)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 17h 40m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
