[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=201751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201751
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/19 04:42
Start Date: 21/Feb/19 04:42
Worklog Time Spent: 10m
Work Description: ryan-williams commented on issue #7876: [BEAM-4775]
Clean up metric protos; support integer distributions, gauges
URL: https://github.com/apache/beam/pull/7876#issuecomment-465859852
Thanks for the feedback, these discussions were very useful for me!
As I mentioned
[here](https://github.com/apache/beam/pull/7876#discussion_r258585934), these
proto changes are basically backwards from the direction they are supposed to
be evolving in.
I'm going to close this out; I think I see how to move the other
#7823-associated PRs forward orthogonally, and probably more simply for not
needing to deal with new proto structures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201751)
Time Spent: 18.5h (was: 18h 20m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 18.5h
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
