[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=202985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202985
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/19 04:28
Start Date: 23/Feb/19 04:28
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7934: [DO NOT
MERGE] [BEAM-4775] add GetJobMetrics RPC
URL: https://github.com/apache/beam/pull/7934#discussion_r259561852
##########
File path: model/fn-execution/build.gradle
##########
@@ -28,3 +28,11 @@ dependencies {
compile project(path: ":beam-model-pipeline", configuration: "unshaded")
runtime project(path: ":beam-model-pipeline", configuration: "shadow")
}
+
+configurations {
Review comment:
this will go away when I move the `MonitoringInfo` protos to model/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 202985)
Time Spent: 19h 10m (was: 19h)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 19h 10m
> Remaining Estimate: 0h
>
> Design doc: [https://s.apache.org/get-metrics-api].
> h1. Relevant PRs in flight:
> h2. Approved / Ready to merge:
> * [#7890|https://github.com/apache/beam/pull/7890]: consolidate MetricResult
> implementations
> * [#7883|https://github.com/apache/beam/pull/7883]: Add
> MetricQueryResults.allMetrics() helper
> h2. Ready for Review:
> * #[7915|https://github.com/apache/beam/pull/7915]: use MonitoringInfo data
> model in Java SDK metrics
> ** Depends on [#7867|https://github.com/apache/beam/pull/7867]
> ** Both of these require adding a {{sdks/java/core}} dependency on the
> {{model/fn-execution}} protos module.
> *** I want to discuss whether that's ok.
> *** It may not be totally necessary; see discussion on
> #[7915|https://github.com/apache/beam/pull/7915].
> h2. Iterating / Discussing:
> * [#7868|https://github.com/apache/beam/pull/7868]: MonitoringInfo URN tweaks
> h2. Merged
> * [#7866|https://github.com/apache/beam/pull/7866]: move function helpers
> from fn-harness to sdks/java/core
> h2. Closed
> * [#7876|https://github.com/apache/beam/pull/7876]: Clean up metric protos;
> support integer distributions, gauges
> h1. Likely pieces still to come:
> I have these implemented in a branch, but need to pull them out into
> manageable PRs:
> * adding the job-API metrics RPC
> * python support
> h1. Previous Description:
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
