[
https://issues.apache.org/jira/browse/BEAM-13478?focusedWorklogId=697960&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-697960
]
ASF GitHub Bot logged work on BEAM-13478:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/21 15:49
Start Date: 17/Dec/21 15:49
Worklog Time Spent: 10m
Work Description: daria-malkova commented on a change in pull request
#16273:
URL: https://github.com/apache/beam/pull/16273#discussion_r771499741
##########
File path: playground/backend/internal/preparators/java_preparators_test.go
##########
@@ -108,3 +110,40 @@ func TestGetJavaPreparators(t *testing.T) {
})
}
}
+
+func Test_changeJavaTestFileName(t *testing.T) {
+ codeWithPublicClass := "package org.apache.beam.sdk.transforms; \n
public class Class {\n public static void main(String[] args) {\n
System.out.println(\"Hello World!\");\n }\n}"
+ path, err := os.Getwd()
+ if err != nil {
+ panic(err)
+ }
+ lc, _ := fs_tool.NewLifeCycle(pb.Sdk_SDK_JAVA, uuid.New(),
filepath.Join(path, "temp"))
+ _ = lc.CreateFolders()
+ defer os.RemoveAll(filepath.Join(path, "temp"))
+ _, _ = lc.CreateSourceCodeFile(codeWithPublicClass)
+ validationResults := sync.Map{}
+ validationResults.Store(validators.UnitTestValidatorName, true)
+
+ type args struct {
+ args []interface{}
+ }
+ tests := []struct {
+ name string
+ args args
+ wantErr bool
+ }{
+ {
+ // Test that file where package is used changes to
import all dependencies from this package
+ name: "original file with package",
+ args:
args{[]interface{}{lc.GetAbsoluteSourceFilePath(), &validationResults}},
+ wantErr: false,
Review comment:
\+ changed the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 697960)
Time Spent: 1h 10m (was: 1h)
> [Playground] Unit tests don't work for Java, need change main JUnit class
> -------------------------------------------------------------------------
>
> Key: BEAM-13478
> URL: https://issues.apache.org/jira/browse/BEAM-13478
> Project: Beam
> Issue Type: Bug
> Components: beam-playground
> Reporter: Daria Malkova
> Assignee: Daria Malkova
> Priority: P3
> Labels: beam-playground-backend
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
