[
https://issues.apache.org/jira/browse/BEAM-13478?focusedWorklogId=698694&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-698694
]
ASF GitHub Bot logged work on BEAM-13478:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Dec/21 14:10
Start Date: 20/Dec/21 14:10
Worklog Time Spent: 10m
Work Description: ilya-kozyrev commented on a change in pull request
#16273:
URL: https://github.com/apache/beam/pull/16273#discussion_r772388420
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -123,27 +118,38 @@ func Process(ctx context.Context, cacheService
cache.Cache, lc *fs_tool.LifeCycl
return
}
+ // Check if unit test
+ isUnitTest := false
+ validateIsUnitTest, ok :=
validationResults.Load(validators.UnitTestValidatorName)
+ if ok && validateIsUnitTest.(bool) {
+ isUnitTest = true
+ }
+
if sdkEnv.ApacheBeamSdk == pb.Sdk_SDK_PYTHON || (sdkEnv.ApacheBeamSdk
== pb.Sdk_SDK_GO && isUnitTest) {
Review comment:
```suggestion
// This condition is used for cases when the playground doesn't
compile source files. For the Python code and the Go Unit Tests
if sdkEnv.ApacheBeamSdk == pb.Sdk_SDK_PYTHON || (sdkEnv.ApacheBeamSdk
== pb.Sdk_SDK_GO && isUnitTest) {
```
##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -123,27 +118,38 @@ func Process(ctx context.Context, cacheService
cache.Cache, lc *fs_tool.LifeCycl
return
}
+ // Check if unit test
+ isUnitTest := false
+ validateIsUnitTest, ok :=
validationResults.Load(validators.UnitTestValidatorName)
+ if ok && validateIsUnitTest.(bool) {
+ isUnitTest = true
+ }
Review comment:
```suggestion
validateIsUnitTest, _ :=
validationResults.Load(validators.UnitTestValidatorName)
isUnitTest := validateIsUnitTest.(bool)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 698694)
Time Spent: 1.5h (was: 1h 20m)
> [Playground] Unit tests don't work for Java, need change main JUnit class
> -------------------------------------------------------------------------
>
> Key: BEAM-13478
> URL: https://issues.apache.org/jira/browse/BEAM-13478
> Project: Beam
> Issue Type: Bug
> Components: beam-playground
> Reporter: Daria Malkova
> Assignee: Daria Malkova
> Priority: P3
> Labels: beam-playground-backend, beam-playground-beta-launch
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
