[
https://issues.apache.org/jira/browse/BEAM-13734?focusedWorklogId=716809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-716809
]
ASF GitHub Bot logged work on BEAM-13734:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/22 00:50
Start Date: 28/Jan/22 00:50
Worklog Time Spent: 10m
Work Description: VictorPlusC commented on a change in pull request
#16601:
URL: https://github.com/apache/beam/pull/16601#discussion_r794113906
##########
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##########
@@ -373,11 +376,24 @@ def get_cache_manager(self, pipeline,
create_if_absent=False):
'/'.join(cache_root_path.parts[1:]), id(pipeline))
else:
cache_dir = tempfile.mkdtemp(dir=cache_root)
+ if not isinstance(pipeline_runner, direct_runner.DirectRunner):
+ _LOGGER.warning(
+ 'A local cache directory has been specified while '
+ 'not using DirectRunner. It is recommended to cache into a '
+ 'GCS bucket instead.')
else:
- cache_dir = tempfile.mkdtemp(
- suffix=str(id(pipeline)),
- prefix='it-',
- dir=os.environ.get('TEST_TMPDIR', None))
+ temp_location = pipeline.options.get_all_options()['temp_location']
Review comment:
Thanks for the feedback. I've replaced the use of temp_location with
staging_location to keep the default directory consistent, do you agree with
this decision?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 716809)
Time Spent: 7h 50m (was: 7h 40m)
> Support cache directories that use GCS buckets
> ----------------------------------------------
>
> Key: BEAM-13734
> URL: https://issues.apache.org/jira/browse/BEAM-13734
> Project: Beam
> Issue Type: New Feature
> Components: runner-py-interactive
> Reporter: Victor Chen
> Assignee: Victor Chen
> Priority: P2
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> * Builds off of the work accomplished under BEAM-13685
> * Modified interactive_environment.py to support caching to a bucket on GCS
> for batch processing pipelines
> * If a specified bucket does not exist, the pipeline will terminate and
> return an error specifying that the bucket does not exist
> * Added cleanup() functionality to cache_manager.py, to enable the
> FileBasedCacheManager class to automatically delete cached values on GCS when
> a bucket path is specified
> * Added docstring to interactive_beam.py with an example of GCS path
> assignment
> * Cached files on GCS will be stored under a directory represented by the
> value of id(pipeline).
> ** Example cached path: gs://my-gcs-bucket/cache/dir/id(pipeline)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
