[ https://issues.apache.org/jira/browse/BEAM-13734?focusedWorklogId=717261&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-717261 ]
ASF GitHub Bot logged work on BEAM-13734: ----------------------------------------- Author: ASF GitHub Bot Created on: 28/Jan/22 20:17 Start Date: 28/Jan/22 20:17 Worklog Time Spent: 10m Work Description: codecov[bot] edited a comment on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#16601](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (848051d) into [master](https://codecov.io/gh/apache/beam/commit/1ae7f6f5485724c989000a5a0ec6564d25de651b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ae7f6f) will **increase** coverage by `37.27%`. > The diff coverage is `35.89%`. > :exclamation: Current head 848051d differs from pull request most recent head b245f65. Consider uploading reports for the commit b245f65 to get more accurate results [![Impacted file tree graph](https://codecov.io/gh/apache/beam/pull/16601/graphs/tree.svg?width=650&height=150&src=pr&token=qcbbAh8Fj1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master #16601 +/- ## =========================================== + Coverage 46.32% 83.59% +37.27% =========================================== Files 201 452 +251 Lines 19734 62117 +42383 =========================================== + Hits 9141 51926 +42785 - Misses 9612 10191 +579 + Partials 981 0 -981 ``` | [Impacted Files](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | `77.35% <ø> (ø)` | | | [...n/apache\_beam/runners/interactive/cache\_manager.py](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9jYWNoZV9tYW5hZ2VyLnB5) | `88.59% <33.33%> (ø)` | | | [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `89.07% <35.71%> (ø)` | | | [...ks/python/apache\_beam/runners/interactive/utils.py](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS91dGlscy5weQ==) | `91.50% <35.71%> (ø)` | | | [...beam/runners/interactive/background\_caching\_job.py](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9iYWNrZ3JvdW5kX2NhY2hpbmdfam9iLnB5) | `94.26% <40.00%> (ø)` | | | [sdks/go/pkg/beam/encoding.go](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9lbmNvZGluZy5nbw==) | | | | [...pkg/beam/core/runtime/xlangx/expansionx/process.go](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUveGxhbmd4L2V4cGFuc2lvbngvcHJvY2Vzcy5nbw==) | | | | [sdks/go/pkg/beam/core/runtime/exec/status.go](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9jb3JlL3J1bnRpbWUvZXhlYy9zdGF0dXMuZ28=) | | | | [sdks/go/pkg/beam/runners/dataflow/dataflow.go](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93Lmdv) | | | | [sdks/go/pkg/beam/io/filesystem/filesystem.go](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9maWxlc3lzdGVtL2ZpbGVzeXN0ZW0uZ28=) | | | | ... and [648 more](https://codecov.io/gh/apache/beam/pull/16601/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1ae7f6f...b245f65](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 717261) Time Spent: 9h 20m (was: 9h 10m) > Support cache directories that use GCS buckets > ---------------------------------------------- > > Key: BEAM-13734 > URL: https://issues.apache.org/jira/browse/BEAM-13734 > Project: Beam > Issue Type: New Feature > Components: runner-py-interactive > Reporter: Victor Chen > Assignee: Victor Chen > Priority: P2 > Time Spent: 9h 20m > Remaining Estimate: 0h > > * Builds off of the work accomplished under BEAM-13685 > * Modified interactive_environment.py to support caching to a bucket on GCS > for batch processing pipelines > * If a specified bucket does not exist, the pipeline will terminate and > return an error specifying that the bucket does not exist > * Added cleanup() functionality to cache_manager.py, to enable the > FileBasedCacheManager class to automatically delete cached values on GCS when > a bucket path is specified > * Added docstring to interactive_beam.py with an example of GCS path > assignment > * Cached files on GCS will be stored under a directory represented by the > value of id(pipeline). > ** Example cached path: gs://my-gcs-bucket/cache/dir/id(pipeline) -- This message was sent by Atlassian Jira (v8.20.1#820001)