[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=222727&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222727
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 00:18
Start Date: 04/Apr/19 00:18
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #8218: [BEAM-3545]
Support Metrics in Go SDK CombineFns
URL: https://github.com/apache/beam/pull/8218#discussion_r271975651
##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -82,15 +82,19 @@ func (ctx *beamCtx) Value(key interface{}) interface{} {
switch key {
case bundleKey:
if ctx.bundleID == "" {
- if id := ctx.Value(key); id != nil {
+ if id := ctx.Context.Value(key); id != nil {
Review comment:
Wondering about the change from ctx.Value -> ctx.Context.Value. It looks
like both behave identically from what I can tell. Is this just a style
improvement? Like to make it explicit that the function is being called on the
embedded struct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 222727)
Time Spent: 10h (was: 9h 50m)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: portability, triaged
> Time Spent: 10h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
