[
https://issues.apache.org/jira/browse/BEAM-3545?focusedWorklogId=222728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222728
]
ASF GitHub Bot logged work on BEAM-3545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/19 00:18
Start Date: 04/Apr/19 00:18
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #8218: [BEAM-3545]
Support Metrics in Go SDK CombineFns
URL: https://github.com/apache/beam/pull/8218#discussion_r271978589
##########
File path: sdks/go/pkg/beam/core/runtime/exec/translate.go
##########
@@ -375,13 +375,15 @@ func (b *builder) makeLink(from string, id linkID)
(Node, error) {
switch op {
case graph.ParDo:
- n := &ParDo{UID: b.idgen.New(), PID: id.to,
Inbound: in, Out: out}
+ n := &ParDo{UID: b.idgen.New(), PID:
transform.UniqueName, Inbound: in, Out: out}
Review comment:
Just checking, this change (id.to -> transform.UniqueName) is because the
value of id.to is a name for the transform local to the link, right? i.e. it's
not unique within the entire graph?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 222728)
Time Spent: 10h (was: 9h 50m)
> Fn API metrics in Go SDK harness
> --------------------------------
>
> Key: BEAM-3545
> URL: https://issues.apache.org/jira/browse/BEAM-3545
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kenneth Knowles
> Priority: Major
> Labels: portability, triaged
> Time Spent: 10h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
