[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=753142&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753142
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/22 23:07
Start Date: 05/Apr/22 23:07
Worklog Time Spent: 10m
Work Description: lostluck commented on code in PR #17265:
URL: https://github.com/apache/beam/pull/17265#discussion_r843336217
##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -631,6 +647,8 @@ func nextRetState(cur retState, transition ReturnKind)
(retState, error) {
return -1, errEventTimeRetPrecedence
case RetValue, RetRTracker:
return rsOutput, nil
+ case RetProcessContinuation:
+ return rsProcessContinuation, nil
Review Comment:
Jack and I talked about this in our 1:1 and I'd prefer avoiding committing
commented out code.
1. The feature isn't very discoverable without associated docs, so there's
little risk in users trying it.
2. We can commit this first if we like, as long as we also change it up to
return an error when we detect a ProcessContinuation is going to be required.
That way we can return a well formed, and clear error that can link to the jira
explaining that this is an in progress feature, that is not yet available.
This avoids awkward code that's commented out, and helps direct users to the
right place to keep an eye on the feature if they want it, and further, we can
test that error occurs explicitly in a test in the beam package, and here.
Issue Time Tracking
-------------------
Worklog Id: (was: 753142)
Time Spent: 3h 20m (was: 3h 10m)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P3
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and
> the programming guide updated with SDF content.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
