[
https://issues.apache.org/jira/browse/BEAM-11104?focusedWorklogId=753360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753360
]
ASF GitHub Bot logged work on BEAM-11104:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/22 12:49
Start Date: 06/Apr/22 12:49
Worklog Time Spent: 10m
Work Description: damccorm commented on code in PR #17265:
URL: https://github.com/apache/beam/pull/17265#discussion_r843909555
##########
sdks/go/pkg/beam/core/funcx/fn.go:
##########
@@ -631,6 +647,8 @@ func nextRetState(cur retState, transition ReturnKind)
(retState, error) {
return -1, errEventTimeRetPrecedence
case RetValue, RetRTracker:
return rsOutput, nil
+ case RetProcessContinuation:
+ return rsProcessContinuation, nil
Review Comment:
> The feature isn't very discoverable without associated docs, so there's
little risk in users trying it.
FWIW, the concern is more about users who are pinned to this release but see
the doc update at a later time (since most sdk consumers aren't going to
immediately update to the latest release)
> We can commit this first if we like, as long as we also change it up to
return an error when we detect a ProcessContinuation is going to be required.
That way we can return a well formed, and clear error that can link to the jira
explaining that this is an in progress feature, that is not yet available.
That's good with me, agreed that its a nicer approach. I'm satisfied as long
as we're not silently continuing or failing at runtime
Issue Time Tracking
-------------------
Worklog Id: (was: 753360)
Time Spent: 3h 50m (was: 3h 40m)
> [Go SDK] DoFn Self Checkpointing
> --------------------------------
>
> Key: BEAM-11104
> URL: https://issues.apache.org/jira/browse/BEAM-11104
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Robert Burke
> Priority: P3
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Allow SplittableDoFns to self checkpoint.
> (To be updated once [https://github.com/apache/beam/pull/13160] is merged and
> the programming guide updated with SDF content.)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
