[
https://issues.apache.org/jira/browse/BEAM-13538?focusedWorklogId=755511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755511
]
ASF GitHub Bot logged work on BEAM-13538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/22 00:57
Start Date: 12/Apr/22 00:57
Worklog Time Spent: 10m
Work Description: codecov[bot] commented on PR #17343:
URL: https://github.com/apache/beam/pull/17343#issuecomment-1095752248
#
[Codecov](https://codecov.io/gh/apache/beam/pull/17343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#17343](https://codecov.io/gh/apache/beam/pull/17343?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(5439a91) into
[master](https://codecov.io/gh/apache/beam/commit/2452e2eccc30ef1b09d9939dc2de27f93ac75f48?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2452e2e) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17343 +/- ##
==========================================
- Coverage 73.94% 73.94% -0.01%
==========================================
Files 684 684
Lines 89519 89519
==========================================
- Hits 66197 66194 -3
- Misses 22162 22165 +3
Partials 1160 1160
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.64% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click
here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment)
to find out more.
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/17343?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17343/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `92.68% <0.00%> (-2.44%)` | :arrow_down: |
|
[...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/17343/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=)
| `92.25% <0.00%> (-0.71%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/17343/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
| `89.98% <0.00%> (-0.15%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/17343?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/17343?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[2452e2e...5439a91](https://codecov.io/gh/apache/beam/pull/17343?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Issue Time Tracking
-------------------
Worklog Id: (was: 755511)
Time Spent: 2h 20m (was: 2h 10m)
> :release:go-license doesn't get the correct version of container boot for
> licenses
> ----------------------------------------------------------------------------------
>
> Key: BEAM-13538
> URL: https://issues.apache.org/jira/browse/BEAM-13538
> Project: Beam
> Issue Type: Bug
> Components: release
> Reporter: Robert Burke
> Priority: P3
> Labels: bash, go, gradle
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Likely has been an issue throughout the lifetime of the code.
> At present the code is pulling the old pre-modules version of the code
> (2.32.0), so 2.33.0 through to present, haven't reflected licences to the go
> boot code. We need to check to see if those releases are missing licenses,
> but I think the risk there is small as the Go code used isn't large.
> The current fix would be to move things to be module aware and pull the v2
> (post module) paths with go-get.
> Our mitigation options in the short term are Be Eager (@master), or Be Stale
> (using @latest), which have the following implications. Being Stale means
> getting the code at the previous release, meaning the licences included *do
> not* include what's new since the last release. This is marginally better
> than present (locked at 2.32.0). Being Eager would mean getting what's at
> Beam Repo Head, which will include the release being built, but be at risk of
> diffs since the cut.
> The first PR is to stopgap into getting us to Be Eager which given the rate
> of change to the boot loaders, to be more accurate.
> The ideal would be to plumb the current release tag being built (or at least
> the short commit ID) so we can get the precise version of the code being
> built for licenses. This Jira is to track that fix.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
