[
https://issues.apache.org/jira/browse/BEAM-13538?focusedWorklogId=755530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755530
]
ASF GitHub Bot logged work on BEAM-13538:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/22 02:05
Start Date: 12/Apr/22 02:05
Worklog Time Spent: 10m
Work Description: youngoli opened a new pull request, #17345:
URL: https://github.com/apache/beam/pull/17345
Cherry-pick of #17343
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 755530)
Time Spent: 3h (was: 2h 50m)
> :release:go-license doesn't get the correct version of container boot for
> licenses
> ----------------------------------------------------------------------------------
>
> Key: BEAM-13538
> URL: https://issues.apache.org/jira/browse/BEAM-13538
> Project: Beam
> Issue Type: Bug
> Components: release
> Reporter: Robert Burke
> Priority: P3
> Labels: bash, go, gradle
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Likely has been an issue throughout the lifetime of the code.
> At present the code is pulling the old pre-modules version of the code
> (2.32.0), so 2.33.0 through to present, haven't reflected licences to the go
> boot code. We need to check to see if those releases are missing licenses,
> but I think the risk there is small as the Go code used isn't large.
> The current fix would be to move things to be module aware and pull the v2
> (post module) paths with go-get.
> Our mitigation options in the short term are Be Eager (@master), or Be Stale
> (using @latest), which have the following implications. Being Stale means
> getting the code at the previous release, meaning the licences included *do
> not* include what's new since the last release. This is marginally better
> than present (locked at 2.32.0). Being Eager would mean getting what's at
> Beam Repo Head, which will include the release being built, but be at risk of
> diffs since the cut.
> The first PR is to stopgap into getting us to Be Eager which given the rate
> of change to the boot loaders, to be more accurate.
> The ideal would be to plumb the current release tag being built (or at least
> the short commit ID) so we can get the precise version of the code being
> built for licenses. This Jira is to track that fix.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)