[
https://issues.apache.org/jira/browse/BEAM-7253?focusedWorklogId=239561&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-239561
]
ASF GitHub Bot logged work on BEAM-7253:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/19 01:50
Start Date: 09/May/19 01:50
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #8537: [BEAM-7253]
test_with_jar_packages_invalid_file_name test fails on Windows
URL: https://github.com/apache/beam/pull/8537#discussion_r282314288
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -200,10 +201,11 @@ def stage_job_resources(self,
# Handle jar packages that should be staged for Java SDK Harness.
jar_packages = options.view_as(
DebugOptions).lookup_experiment('jar_packages')
+ classpath_separator = ':' if platform.system() != 'Windows' else ';'
Review comment:
I think there’s no issue to use ‘;’ on all platforms. ‘:’ is a standard
classpath separator on Linux systems so some people on Linux may find that
using ‘;’ for separating jar files makes them feel awkward but it’s not a
classpath anyway. Do you think it would be better to use a single character of
choice for all platforms?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 239561)
Time Spent: 40m (was: 0.5h)
> test_with_jar_packages_invalid_file_name test fails on windows
> --------------------------------------------------------------
>
> Key: BEAM-7253
> URL: https://issues.apache.org/jira/browse/BEAM-7253
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Heejong Lee
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> test_with_jar_packages_invalid_file_name test fails on windows. possibly
> different class path separator on windows ";" as compared to linux ":".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
