[
https://issues.apache.org/jira/browse/BEAM-7253?focusedWorklogId=240396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240396
]
ASF GitHub Bot logged work on BEAM-7253:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/May/19 20:29
Start Date: 10/May/19 20:29
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #8537:
[BEAM-7253] test_with_jar_packages_invalid_file_name test fails on Windows
URL: https://github.com/apache/beam/pull/8537#discussion_r283032601
##########
File path: sdks/python/apache_beam/runners/portability/stager.py
##########
@@ -200,10 +201,11 @@ def stage_job_resources(self,
# Handle jar packages that should be staged for Java SDK Harness.
jar_packages = options.view_as(
DebugOptions).lookup_experiment('jar_packages')
+ classpath_separator = ':' if platform.system() != 'Windows' else ';'
Review comment:
Yeah, let's use a single separator (prefer colon) to make things simpler and
offer a platform-independent API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 240396)
Time Spent: 1h 20m (was: 1h 10m)
> test_with_jar_packages_invalid_file_name test fails on windows
> --------------------------------------------------------------
>
> Key: BEAM-7253
> URL: https://issues.apache.org/jira/browse/BEAM-7253
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Heejong Lee
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> test_with_jar_packages_invalid_file_name test fails on windows. possibly
> different class path separator on windows ";" as compared to linux ":".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
