[
https://issues.apache.org/jira/browse/BEAM-7239?focusedWorklogId=241129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-241129
]
ASF GitHub Bot logged work on BEAM-7239:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/May/19 15:33
Start Date: 13/May/19 15:33
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #8565: [BEAM-7239] Do
not close DataSource on Teardown on JdbcIO
URL: https://github.com/apache/beam/pull/8565
DataSource implementations do not necessarily implement close() and even
if so, it may make sense not to close them systematically on @Teardown
because they could be provided for a longer lifecycle than the DoFn
thread, e.g. PoolableDataSource.
R: @aromanenko-dev
CC: @jbonofre
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 241129)
Time Spent: 3h 40m (was: 3.5h)
> Add withDataSourceProviderFn() to JdbcIO
> ----------------------------------------
>
> Key: BEAM-7239
> URL: https://issues.apache.org/jira/browse/BEAM-7239
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Fix For: 2.13.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> We have been manually tuning Datasource creation, a better approach would be
> to generalize this and allow users to parametrize their DataSource creation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
